Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip rewriting modulemaps if not changed to fix issues with pch #6212

Merged
merged 5 commits into from Apr 22, 2024

Conversation

waltflanagan
Copy link
Member

Fixes #6211

Short description 📝

Addes a hash check to SwiftPackageManagerModuleMapGenerator to only write file contents when they have changed.

How to test the changes locally 🧐

See #6211

Contributor checklist ✅

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@waltflanagan waltflanagan enabled auto-merge (squash) April 21, 2024 02:09
@waltflanagan waltflanagan requested review from fortmarek and removed request for fortmarek April 21, 2024 02:10
@waltflanagan waltflanagan merged commit 01eeb8f into main Apr 22, 2024
8 checks passed
@waltflanagan waltflanagan deleted the pch_problems branch April 22, 2024 06:47
@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Apr 22, 2024
@fortmarek fortmarek changed the title Only write module map files if the contents change. Skip rewriting modulemaps if not changed to fix issues with pch Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tuist generate requires clean build when dependencies with module maps are referenced in a precompiled header.
3 participants