Fix regression in ModuleMapMapper due to outdated Graph properties #6221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description π
The latest release contains a regression due to: #6218
The regression happened because:
ModuleMapMapper
is no longer called that early in the process before other mappers update the graphtargets
anddependencies
are available in two ways. In mappers, we don't always update both properties (in this caseGraph.dependencies
andTarget.dependencies
) which makes the other one outdated. That's exactly what happened here.The solution for now is to access target dependencies through
GraphTraverser
but long-term, we should get rid of these duplicated properties altogether, so bugs like this are no longer possible.How to test the changes locally π§
Run
tuist generate
when using binaries.Contributor checklist β
mise run lint:fix
Reviewer checklist β
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry