Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align bundle name sanization with SPM #6234

Merged
merged 17 commits into from Apr 25, 2024
Merged

Align bundle name sanization with SPM #6234

merged 17 commits into from Apr 25, 2024

Conversation

danibachar
Copy link
Collaborator

Resolves #6232

Short description 📝

Replace "-" with "_" only for target names
This is a direct continuation for #6146
Once the above is merged we can merge this fix as well

How to test the changes locally 🧐

See - #6232

Contributor checklist ✅

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

Daniel Bachar and others added 15 commits April 2, 2024 14:56
Comply to SPM bundle accessors
10a7f25
unit tests fix
46ffe6e
templates updates
b9d80ee
small fixes
1cf1817
Updates
70553b3
Merge branch 'main' into danibachar/spm-complaince-to-bundler-accessor
612dbc3 
# Conflicts:
#	Sources/TuistGenerator/Mappers/ResourcesProjectMapper.swift
#	Tests/TuistGeneratorTests/ProjectMappers/ResourcesProjectMapperTests.swift
removed duplicated bundle module symbol
cfd2e0e
lint
85cd258
@danibachar
Merge branch 'main' into danibachar/spm-complaince-to-bundler-accessor
303c85d
PR fixes
6f710d6
@danibachar
Merge branch 'main' into danibachar/spm-complaince-to-bundler-accessor
87ee5b2
MR fixes
166f1ed
Fix bundle name parsing
df2f26b
Adding naming tests
5b56c91
Merge branch 'main' into danibachar/file-synitizer-bundle-name
942fdfa 
# Conflicts:
#	Sources/TuistGenerator/Mappers/ResourcesProjectMapper.swift
#	Tests/TuistGeneratorTests/ProjectMappers/ResourcesProjectMapperTests.swift
@danibachar danibachar changed the title Danibachar/file synitizer bundle name Fix file sanitizer bundle name formatting Apr 24, 2024
fortmarek
fortmarek approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@fortmarek fortmarek left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix 🙌

We can merge once the lint job succeeds

@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Apr 24, 2024
@fortmarek fortmarek changed the title Fix file sanitizer bundle name formatting Align bundle name sanizations with SPM Apr 24, 2024
@fortmarek fortmarek changed the title Align bundle name sanizations with SPM Align bundle name sanization with SPM Apr 24, 2024
@danibachar
Copy link
Collaborator Author

Looks good, thanks for the fix 🙌

We can merge once the lint job succeeds

Fixed

@fortmarek fortmarek merged commit 492b350 into tuist:main Apr 25, 2024
8 checks passed
@danibachar danibachar deleted the danibachar/file-synitizer-bundle-name branch May 3, 2024 04:13
@cristi-lupu cristi-lupu mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortmarek fortmarek fortmarek approved these changes

Assignees
No one assigned
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If project name contains "-" and contains bundles, we are changing the project name for bundle
2 participants
@danibachar @fortmarek