Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure custom search path settings are included in generated projects #751

Merged
merged 3 commits into from Dec 5, 2019
Merged

Ensure custom search path settings are included in generated projects #751

merged 3 commits into from Dec 5, 2019

Commits on Dec 5, 2019

  1. Ensure custom search path settings are included in generated projects 

    - The previous logic was setting the `$(inherited)` and the derived search paths seperately
- This caused the derrived search paths to replace any existing custom settings
- To solve this, we can set the derived search paths and the `$(inherited)` setting as one setting
- This allows the extend helper method to extend existing settings

Test Plan:

- Run `tuist generate` within `fixtures/ios_app_with_static_libraries`
- Inspect the generated workspace, Module A should have a `$(SRCROOT/CustomHeader` header search path
    @kwridan
    kwridan committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    ff22983 View commit details
    Browse the repository at this point in the history

  2. update change log

    @kwridan
    kwridan committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    0f583fa View commit details
    Browse the repository at this point in the history

  3. Ensure paths are sorted

    @kwridan
    kwridan committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    30fc139 View commit details
    Browse the repository at this point in the history