Add RxSwift as a dependency of TuistKit #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
kwridan and
ollieatkinson
and removed request for
a team
|
@pepibumur your pull request is missing a changelog! |
lakpa
reviewed
Dec 7, 2019
| @@ -27,6 +27,7 @@ Please, check out guidelines: https://keepachangelog.com/en/1.0.0/ | |||
| - Make scheme generation methods more generic https://github.com/tuist/tuist/pull/730 by @adamkhazi @kwridan. | |||
| - Make scheme generation methods more generic by @adamkhazi @kwridan. | |||
| - `SimulatorController` with method to fetch the runtimes https://github.com/tuist/tuist/pull/746 by @pepibumur. | |||
| - Add RxSwift as a dependency of `TuistKit` https://github.com/tuist/tuist/pull/760 by @pepibumur. | |||
There was a problem hiding this comment.
wondering if we will limit the usage of RxSwift as migrating to Combine may require considerable efforts
There was a problem hiding this comment.
It's fine. If at some point we consider migrating we can do it gradually. I'd not worry about that too much.
lakpa
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 馃摑
With the introduction of caching, we'll need to perform operations in parallel, for example pulling the frameworks from the cache. Modelling them with a reactive interface makes the asynchronous logic easier to reason about.
What
I'm introducing RxSwift as a dependency of
TuistKit.Why not Combine? Combine is only available from macOS 10.15.x and there might be users using
tuistwith lower versions of macOS. Since the usage of RxSwift will be scoped to just the asynchronous operations required for caching, should be easy to replace with Combine once we drop the support for macOS 10.14.x