Support modifying Tuist's directories with environment variables #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pepibumur your pull request is missing a changelog! |
andreacipriani
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 馃摑
Some Tuist's features, like storing Tuist versions, interact with some global directories in the system. That makes it difficult to write deterministic acceptance tests because those directories might already contain some data that might cause the tests to fail.
Solution 馃摝
This PR makes the versions and the cache directories customizable through environment variables. Thanks to it we can set those variables from the acceptance tests and prevent Tuist from interacting with a shared space in the environment.