Fix unstable scheme generation #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwridan
approved these changes
Dec 15, 2019
lakpa
reviewed
Dec 15, 2019
| @@ -572,7 +572,7 @@ final class SchemesGenerator: SchemesGenerating { | |||
| private func commandlineArgruments(_ arguments: [String: Bool]) -> [XCScheme.CommandLineArguments.CommandLineArgument] { | |||
| arguments.map { key, enabled in | |||
| XCScheme.CommandLineArguments.CommandLineArgument(name: key, enabled: enabled) | |||
| } | |||
| }.sorted { $0.name < $1.name } | |||
There was a problem hiding this comment.
Does order matter when generating schemes?
There was a problem hiding this comment.
Wondering, why there are differences in order when generating subsequent times, can we identify the root cause of the problem?
There was a problem hiding this comment.
Generally it does, but this change is not regressing as the order is currently indeterministic. Please check #791 for more details.
There was a problem hiding this comment.
@lakpa Arguments are stored as a dictionary in the manifest, that's why they're shuffled.
public struct Arguments: Equatable, Codable {
public let environment: [String: String]
public let launch: [String: Bool]
public init(environment: [String: String] = [:],
launch: [String: Bool] = [:]) {
self.environment = environment
self.launch = launch
}
}
lakpa
approved these changes
Dec 15, 2019
pepicrft
approved these changes
Dec 16, 2019
|
Good to merge! |
|
Nice fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Running
tuist generatesecond time without modifying the project can result in unexpected differences in project.xcschemefiles.Solution 📦
Sort both arguments and environment variables by name during the generation process.
Implementation 👩💻👨💻