Add related test targets as testables

[vytis]

Resolves #569

Short description 📝

It should be possible to run tests if target has any test targets.

Solution 📦

This PR finds all related test targets to the test scheme. It was already done for test targets themselves, but the functionality was extended to include all other targets.

Implementation 👩‍💻👨‍💻

• Added implementation
• Added tests

Test Plan 🛠

Run with app_with_framework_and_tests fixture and check that in generated schemes:

Previous behaviour didn't break

1. AppTests scheme has AppTests as a testable target.
2. FrameworkTests scheme has FrameworkTests as a testable target.

New behaviour works as expected

1. App scheme has AppTests as a testable target.
2. Framework scheme has FrameworkTests as a testable target.

[github-actions]

@vytis your pull request is missing a changelog!

[kwridan]

Thanks for looking into this @vytis

Regarding testing you are right it doesn't look like there's a wholistic test for the scheme generator, a few options for us:

1. create another internal method with a similar signature to generateProjectSchemes except this one doesn't write to disk, but returns the [Scheme] which would allow us to unit test it without ever needing to go to disk (should be faster and much more reliable)

2. We can make createDefaultScheme internal to unit test that one method

Hope this helps!

[kwridan]

As a suggestion, we can limit the scope of the search to targets within the same project as opposed to the whole workspace

A few ways we can go about it:

1. Scan project targets directly

targetNode.project
          .targets
          .filter { $0.product.testsBundle }
          .filter { $0.dependencies.contains(.target(name: targetNode.name)) }
          .map { TargetReference.project(path: targetNode.project.path, target: $0.name) }
// ...

2. Add another helper to the graph

In graph we could introduce another method:

/// Returns all target nodes at a given path (i.e. all target nodes in a project)
public func targetNodes(at path: AbsolutePath) -> [TargetNode] {
        guard let nodes = cache.targetNodes[path] else {
            return []
        }
        return Array(nodes.values)
    }

[vytis]

Makes sense, I was thinking what could be the performance impact of looping through all targets. Only looking through project targets sounds much better.

[vytis]

@kwridan I added the helper, might be useful in other places too

[vytis]

@kwridan I have added tests and addressed the points you raised. I think it's ready for review 🤞

[pepicrft]

What about moving this logic to the Graph model? Something along the lines of:

func testableDependants(of: TargetNode) -> [TargetNode]

[vytis]

@pepibumur updated!

[pepicrft]

Just a minor thing but it looks good overall. 👏 good job @vytis

[pepicrft]

Thanks @vytis. The PR looks great on my side. Let's wait for one more review from @kwridan and we can merge afterward.

[kwridan]

nice work @vytis

Tested it out on a few fixtures 👍