Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge qa with master #50

Merged
merged 7 commits into from
Mar 4, 2020
Merged

Merge qa with master #50

merged 7 commits into from
Mar 4, 2020

Conversation

sensei100
Copy link
Contributor

No description provided.

cmharlow and others added 7 commits November 5, 2019 15:14
* BL-897 Refactor library_facet field

- Use ITM field instead of HLD field to retrieve library. 
- Will not include libraries with missing or lost items, in addition to items in RES_SHARE
- Returns library names only once
- Adds tests for this method

* Allow failures on jruby

* Remove unused Ruby versions from travis
* BL-1101 Finding aids logic

- The original finding aids/more links logic was built with http addresses.
- Since the library now uses https, we need to add that logic in.
- Some of the old records still have http, so we need to handle both instances.

* Update lib/cob_index/macros/custom.rb

Co-Authored-By: David Kinzer <dtkinzer@gmail.com>

* Fix syntax error

* Fix syntax error

Co-authored-by: David Kinzer <dtkinzer@gmail.com>
- Records should be suppressed if they have no HLD or PRT fields as long as there is also no 856["u"] present
Update the way we display Illegal Aliens and variants for subject displays.
Update subject display for field 650, subfield a
@sensei100 sensei100 requested a review from dkinzer March 4, 2020 16:05
@dkinzer dkinzer merged commit ec690a0 into master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants