Allow a library user to call consumer->disconnect() and for it to stop reconnect attempt #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests pass on my local machine, something weird is up with the CI.
|
everhardt
added a commit
to everhardt/kafkajs
that referenced
this pull request
Nov 13, 2023
updated version of tulios#1148 and tulios#1462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #1147
When a library user calls disconnect and the library is trying to reconnect to a kafka node, the disconnect is effectively ignored.
A library user cannot call disconnect and expect the library to stop reconnecting. Effetively leading to leaked resources.
This change fixes that issue.