#1147 Allow disconnect on rebalance, currently if trying to rebalance kafka… #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will not disconnect properly if disconnect is called.
samueltuckey
changed the title
trentstehbenshl
approved these changes
Oct 14, 2022
…emains consistent
… if allowRecconectAfterRebalance is set to false, the consumer wont try to reconnect. Also update the typescript definition
…ustralia/kafkajs into HLCLOUD-682-disconnect-on-rebalance
|
@tulios @Nevon It does not change the default or affect any of the default behaviour that kafkajs provides it should not cause any problems to existing code. Given the way the unit tests are structured, I am unsure about the way to engineer a unit test. Any recommendations would be appreciated. typescript definitions are updated. Please give me advice on how to get this pull request accepted. Thanks in advance for your time. |
trentstehbenshl
approved these changes
Oct 21, 2022
everhardt
added a commit
to everhardt/kafkajs
that referenced
this pull request
Nov 13, 2023
updated version of tulios#1148 and tulios#1462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the bug where if we call disconnect on kafka consumer and a rebalance is in process then the disconnect does not work.
#1147