Renamed restricted keyword parameter #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a restricted keyword is considered bad practice and also causes an issue In [Terser](https://github.com/terser-js/terser): ``` ERROR in handlers/versions/activate-version.js from Terser Unexpected token: operator (=) [./node_modules/kafkajs/src/producer/eosManager/transactionStateMachine.js:16,34][handlers/versions/activate-version.js:48083,54] ```
|
Thanks for the contribution! I'm quite confident that this is a bug in terser, as |
|
@Nevon Thanks for the quick reply! Having this workaround merged would be great as I'm currently using my Fork. |
|
Thanks so much for the merge. Would it be possible to get an npm release as well? :) |
|
Since we have some other unreleased changes in master I would like to first run master in production for a little while, but we should be able to cut a new version pretty soon. For now, you could pin your dependency to 77a7e03 if you want to help test it out. |
|
@jacktuck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a restricted keyword is considered bad practice and also causes an issue In Terser:
I created an issue on Terser project too but perhaps they handle it correctly already.
terser/terser#329