Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #454 proposal - Adding validation to connectionBuilder #460

Merged
merged 3 commits into from
Aug 9, 2019
Merged

Issue #454 proposal - Adding validation to connectionBuilder #460

merged 3 commits into from
Aug 9, 2019

Conversation

capucho
Copy link
Contributor

@capucho capucho commented Aug 8, 2019

Proposal for issue #454

@capucho capucho changed the title Adding validation to connectionBuilder Issue #454 proposal - Adding validation to connectionBuilder Aug 8, 2019
Nevon
Nevon requested changes Aug 9, 2019
View reviewed changes
Copy link
Collaborator

@Nevon Nevon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KafkaJSConnectionError is a retriable error (it inherits KafkaJSError which is retriable by default). Since retrying wouldn't change the list of brokers, this should be non-retriable.

@Nevon Nevon mentioned this pull request Aug 9, 2019
Closed
@Nevon Nevon merged commit dc0a942 into tulios:master Aug 9, 2019
@Nevon Nevon mentioned this pull request Aug 10, 2019
Closed
@julien-marchand julien-marchand mentioned this pull request Feb 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nevon Nevon Nevon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@capucho @Nevon