Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message when broker list is empty #454

Closed
miton18 opened this issue Aug 6, 2019 · 2 comments
Closed

Better error message when broker list is empty #454

miton18 opened this issue Aug 6, 2019 · 2 comments
Labels
enhancement good first issue help wanted

Comments

@miton18
Copy link

miton18 commented Aug 6, 2019

When, by a misconfiguration, you try to instantiate a new Kafka({ brokers: [] })

The error is not very easy to understand:

TypeError: Cannot read property 'split' of undefined

caused by https://github.com/tulios/kafkajs/blob/master/src/cluster/connectionBuilder.js#L24

we can easily check brokers.length before doing anything
@miton18
Copy link
Author

miton18 commented Aug 8, 2019

Proposal #458

@capucho capucho mentioned this issue Aug 8, 2019
Merged
Nevon added a commit that referenced this issue Aug 9, 2019
@Nevon
Merge pull request #460 from capucho/adding-validation-to-connection-…
dc0a942 
…builder

Issue #454 proposal - Adding validation to connectionBuilder
@Nevon
Copy link
Collaborator

Nevon commented Aug 10, 2019

Fixed in #460.

@Nevon Nevon closed this as completed Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tulios @Nevon @miton18