Randomize order of seed brokers #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows spreading the initial connection load towards the brokers, we shuffle the order of the seed brokers. They are still iterated through in the same way when a connection fails, just not necessarily in the same order they were originally specified. Fixes #631
Nevon
commented
Jan 14, 2020
| const { host, port } = builder.build() | ||
| return `${host}:${port}` | ||
| }) | ||
| expect(connections).toIncludeSameMembers(brokers) |
There was a problem hiding this comment.
This validates that all of the brokers are returned, just not in the same order.
tulios
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows spreading the initial connection load towards the brokers by shuffling the the order of the seed brokers. They are still iterated through in the same way when a connection fails, just not necessarily in the same order they were originally specified.
Fixes #631
FYI @fjuan