Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added listGroup method to admin interface #645

Merged
merged 6 commits into from
Feb 24, 2020
Merged

Added listGroup method to admin interface #645

merged 6 commits into from
Feb 24, 2020

Conversation

dfilkovi
Copy link
Contributor

No description provided.

Nevon
Nevon requested changes Feb 23, 2020
View reviewed changes
Copy link
Collaborator

@Nevon Nevon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Overall I think it looks good. There are just a lot of small issues to take care of before we can merge this. Let me know if anything is unclear or if you need help with anything.

src/admin/__tests__/deleteTopics.spec.js Outdated Show resolved Hide resolved
src/admin/__tests__/listGroups.spec.js Outdated Show resolved Hide resolved
src/admin/__tests__/listGroups.spec.js Outdated Show resolved Hide resolved
src/admin/__tests__/listGroups.spec.js Show resolved Hide resolved
src/admin/__tests__/listGroups.spec.js Outdated Show resolved Hide resolved
src/protocol/requests/listGroups/v0/response.js Outdated Show resolved Hide resolved
src/protocol/requests/listGroups/v2/request.js Outdated Show resolved Hide resolved
src/protocol/requests/listGroups/v3/request.js Outdated Show resolved Hide resolved
src/protocol/requests/listGroups/v3/response.js Outdated Show resolved Hide resolved
src/protocol/requests/listGroups/v3/response.js Show resolved Hide resolved
@dfilkovi
Copy link
Contributor Author

Found out that I need to query all brokers for groups, change applied

Nevon
Nevon requested changes Feb 24, 2020
View reviewed changes
Copy link
Collaborator

@Nevon Nevon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one thing left, and then it looks good to merge to me.

src/admin/index.js Outdated Show resolved Hide resolved
@Nevon Nevon merged commit 6863075 into tulios:master Feb 24, 2020
@Nevon
Copy link
Collaborator

Nevon commented Feb 24, 2020

Thanks for the contribution! This will be out in the next beta version.

@ankon ankon mentioned this pull request Aug 4, 2020
Closed
@lafeuil lafeuil mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nevon Nevon Nevon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dfilkovi @Nevon @dariofilkovic