Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid topics from targetTopics on INVALID_TOPIC_EXCEPTION #666

Merged
merged 3 commits into from
Mar 18, 2020

Conversation

Nevon
Copy link
Collaborator

@Nevon Nevon commented Mar 16, 2020

Fixes #665

@Nevon Nevon added the bug label Mar 16, 2020
@Nevon Nevon requested review from tulios and JaapRood March 16, 2020 13:46
src/cluster/index.js Outdated Show resolved Hide resolved
@Nevon Nevon requested a review from JaapRood March 17, 2020 08:12
Copy link
Collaborator

@JaapRood JaapRood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Nevon Nevon merged commit 897715f into master Mar 18, 2020
@Nevon Nevon deleted the reproduce-665 branch March 18, 2020 09:55
@ankon
Copy link
Contributor

ankon commented Apr 7, 2020

Mostly FYI: It seems I'm able to hit a lock timeout for this new lock in our production environment. What is worrying here is the number of "waiting locks" in the log messages goes continuously up, starting from 2 to 1789 after several hours when I finally killed the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KafkaJSProtocolError: The request attempted to perform an operation on an invalid topic
3 participants