Delete the entry for the waiter when the timeout is reached #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix one aspect of the problem mentioned in #666 (comment): We should be able to continue, even after a client has hit the timeout. I still need to find the reason for timeout, but I think this is independent and might be more caused by what my application code is doing with KafkaJS. |
Nevon
approved these changes
Apr 8, 2020
Nevon
reviewed
Apr 8, 2020
When the lock times out the promise rejects, and the calling code will do "something sensible". Something sensible could be to retry later -- but that actually requires the lock to be able to be acquired again. Right now this is not possible, because the failed `tryToAcquire` is still inside the waiting queue -- and will never release the lock.
ankon
force-pushed
the
pr/lock-delete-waiter-on-timeout
branch
from
42c15be
to
86ef01b
Compare
Changed. I added a comment as well, so that readers of the code won't be too confused :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the lock times out the promise rejects, and the calling code will do "something sensible". Something sensible
could be to retry later -- but that actually requires the lock to be able to be acquired again. Right now this is
not possible, because the failed
tryToAcquireis still inside the waiting queue -- and will never release the lock.