Add ACL functions to admin client

[shubhanilBag]

Resolves issue: #465

[Nevon]

This is a really solid contribution! Thank you so much. I left some comments on things we should address, but in large this is really good.

[Nevon]

Delete these unused imports.

[Nevon]

See #649 (comment) for some issues regarding RESOURCE_TYPES.

Basically, we have been misusing ResourceTypes for configs, when they are supposed to be used in the way that you are here, for ACLs. So before we start having more people use ResourceTypes, I would like to figure out a good way to split the two so that we have CONFIG_RESOURCE_TYPES and ACL_RESOURCE_TYPES.

The old RESOURCE_TYPES still needs to be exported for backwards compatibility until we decide to release a major version, but it would be good if we can prepare by having most people already now import either CONFIG_RESOURCE_TYPES or ACL_RESOURCE_TYPES, so that the break affects fewer people.

So what I would suggest is that we within this PR introduce ACL_RESOURCE_TYPES, which is just the old RESOURCE_TYPES re-exported under a different name, and use that in all examples and tests.

[Nevon]

In fact, we should probably prefix all the ACL-related protocol types with ACL_ just to avoid this in the future.

[shubhanilBag]

@Nevon SGTM, let's do that, also I would suggest to keep types in a separate folder like: src/protocol/types/ACL/Resource.js or src/protocol/types/ACLResources.js

[Nevon]

We try to avoid numeric for loops unless necessary. A simple for (let filterResponse of data.filterResponses) would be preferred.

[shubhanilBag]

@Nevon Thanks for the thorough review! I opened the draft PR to check if the basic ACL test is working in the CI. I am still working to on it to make it ready for review, that's includes code cleanup, separating the test case into separate files, more proper validation checks in the admin client and others including your suggestions 😄

[EricMCornelius]

Anything I can do to assist in getting this feature moving along?

[tulios]

Hey @EricMCornelius, I will take over this PR soon and make sure it gets merged. We had other priorities but now it's the time to get this one in.

[tulios]

Step 1 to get this to master (#898)

[tulios]

@Nevon take a final look, it's all good for me now.

[tulios]

I forgot about the Typescript types, that's still missing. I can add it later.

[Nevon]

v1 of all the *Acls APIs return the responses before throttling, meaning that we should support client side throttling. That's already been implemented on the network layer, so all you have to do on the protocol level is to copy the throttleTime property to a clientSideThrottleTime property on the decoded object and the rest is handled automatically (see

kafkajs/src/protocol/requests/heartbeat/v2/response.js

Lines 11 to 18 in 900c60a

	const decode = async rawData => {
	const decoded = await decodeV1(rawData)
	return {
	...decoded,
	clientSideThrottleTime: decoded.throttleTime,
	}
	}

for example)

[tulios]

The PR is also missing protocol and broker tests, I will add those before I merge.