Add support to SASL SCRAM #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nevon
requested changes
Jun 7, 2018
src/network/connection.js
Outdated
| @@ -313,6 +319,11 @@ module.exports = class Connection { | |||
|
|
|||
| // The full payload is loaded, erase the temporary buffer | |||
| this.buffer = Buffer.alloc(0) | |||
|
|
|||
| if (this.authHandlers && this.authExpectResponse) { | |||
There was a problem hiding this comment.
I think you can remove the second condition
|
|
||
| const finalMessageWithoutProof = this.finalMessageWithoutProof(clientMessageResponse) | ||
| const clientProof = await this.clientProof(clientMessageResponse) | ||
| const finalMessage = `${finalMessageWithoutProof},p=${clientProof}` |
There was a problem hiding this comment.
All this p, r, n etc. is reminding me of node-postgres. I would suggest to extract them to named constants so that I don't have to read the RFC to understand what they all mean.
There was a problem hiding this comment.
I don't think naming this different will help; it's better to have a close mapping to the RFC. This is also "standardized", anyone reading SCRAM code will easily find the components of the message instead of parsing our understanding of it. WDYT?
Nevon
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71