fix(consumer): Runner#waitForConsumer uses consuming stop event instead of timers #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankon
reviewed
May 27, 2020
|
Could you, please, clarify ability of this PR will be merged and released next days? |
|
Thanks for fixing this. I somehow missed both the original PR and your comment yesterday. Although I instinctively feel strange about making the runner an EventEmitter only so that it can listen to its own event, the solution is simple and contained enough that if we later decide to refactor it it's very easy to do so. As soon as the pipeline has run, I will merge, after which it will be available in a pre-release build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #723