Support LOG_APPEND_TIME record timestamps #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a topic is configured with `message.timestamp.type=LogAppendTime` the timestamp on the record should be set to the `maxTimestamp` of the recordbatch rather than the usual `firstTimestamp + timestampDelta`. Fixes #768
JaapRood
approved these changes
Aug 18, 2020
|
That shouldn't be needed, as we don't expose the Fetch response, which is the only data structure that has changed in any way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a topic is configured with
message.timestamp.type=LogAppendTimethe timestamp on the record should be set to themaxTimestampof the recordbatch rather than the usualfirstTimestamp + timestampDelta.https://cwiki.apache.org/confluence/display/KAFKA/KIP-32+-+Add+timestamps+to+Kafka+message
Fixes #768