Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix acl type declarations to match implementation #941

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Fix acl type declarations to match implementation #941

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b4c287
Fix acl type declarations to match implementation
Oct 31, 2020
b87d540
Fix acl type declaration tests
Nov 3, 2020
9b93ada
Merge branch 'master' into fix-acl-type-discrepancy
Nevon Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/index.d.ts
View file
Open in desktop
Expand Up @@ -370,7 +370,7 @@ export interface AclResource {
export type AclEntry = Acl & AclResource

export type DescribeAclResource = AclResource & {
acls: Acl[]
acl: Acl[]
}

export interface DescribeAclResponse {
Expand Down Expand Up @@ -454,7 +454,7 @@ export type Admin = {
describeGroups(groupIds: string[]): Promise<GroupDescriptions>
describeAcls(options: AclFilter): Promise<DescribeAclResponse>
deleteAcls(options: { filters: AclFilter[] }): Promise<DeleteAclResponse>
createAcls(options: { acls: AclEntry[] }): Promise<boolean>
createAcls(options: { acl: AclEntry[] }): Promise<boolean>
deleteTopicRecords(options: { topic: string; partitions: SeekEntry[] }): Promise<void>
logger(): Logger
on(
Expand Down
4 changes: 2 additions & 2 deletions types/tests.ts
View file
Open in desktop
Expand Up @@ -220,12 +220,12 @@ const runAdmin = async () => {
resourceType: r.resourceType,
resourceName: r.resourceName,
resourcePatternType: r.resourcePatternType,
acls: r.acls,
acls: r.acl,
})),
})

const createAcls = await admin.createAcls({
acls: [
acl: [
{
resourceType: AclResourceTypes.TOPIC,
resourceName: 'topic-name',
Expand Down