Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix acl type declarations to match implementation #941

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Fix acl type declarations to match implementation #941

merged 3 commits into from
Nov 4, 2020

Conversation

curtiseppel
Copy link
Contributor

@curtiseppel curtiseppel commented Nov 3, 2020 •
edited
Loading

The Javascript implementation of createAcls doesn't match the Typescript type declarations

Fix acl type declaration tests
b87d540 
Do these even run? Wouldnt it have caught this error?
@Nevon
Copy link
Collaborator

Nevon commented Nov 4, 2020

Thanks for the fix!

@Nevon Nevon merged commit 668b85e into tulios:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nevon Nevon Nevon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curtiseppel @Nevon