Add ConnectWithTimeout method to support having a timeout when connecting. #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aliwoto <aminnimaj@gmail.com>
…thod. Signed-off-by: Aliwoto <aminnimaj@gmail.com>
ALiwoto
changed the title
|
Can you say a word or two about the motivation and concrete failure mode which triggered this? I'm seeing timeout related issues and wonder if this was indirectly made to address a functionally equal failure mode as the one I observe. I'm not currently using a timeout on the service, but when connecting to the whatsmeow service socket, I use a timeout of 15 seconds within the application. This seems to cause cascading issues some times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new method called
ConnectWithTimeoutto support having a timeout set when connecting to whatsapp. Thiscontext.Conextis later on passed to fs and is used when connecting (previously, we have been usingcontect.Backgound()for the fs).Can also use
context.Background()if we do not want any timeout.