-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjust grid for mobile #231
base: dev
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
If you have time left a few minor things: In opportunities when having a screen <440px.
When additing questionaires:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the changes are great and look good. Just some more fixes to make the UI more smooth. I will be commenting a summary.
app/layout.tsx
Outdated
@@ -11,7 +11,7 @@ interface Props { | |||
export default function RootLayout({ children }: Props) { | |||
return ( | |||
<html lang="en"> | |||
<body> | |||
<body className=""> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a redundant change, can be taken out.
tailwind.config.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the default breakpoint widths, not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor changes that I added under comments and conflict resolutions then you're done :)
id: application?.opportunityId, | ||
}, | ||
}).then((opportunity) => opportunity?.title); | ||
const opportunityTitle = db.opportunity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you didn't write this but please make this a TRPC query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
components/header/index.tsx
Outdated
{session?.user ? ( | ||
<UserComponent user={session.user} /> | ||
) : ( | ||
<Button asChild variant="outline" size="sm"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sign in button styling is now different, please ensure it stays consistent with the dev branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust space for mobile (not sure if this is all that is needed)