Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for standard ROS PoseStamped message #13

Closed
wants to merge 3 commits into from
Closed

Add support for standard ROS PoseStamped message #13

wants to merge 3 commits into from

Conversation

mhkabir
Copy link

@mhkabir mhkabir commented Sep 20, 2014

This message can be used for direct vehicle state estimation or control, for people who are using LSD_SLAM onboard quadrotors, ground robots, etc. You may fuse this with metric sensor data like IMU, baro, etc. to get scaled metric measurements.

Coordinate frame : Z out of camera , Y down, X right.

pMsg.pose.orientation.w *= -1;
}

pMsg.header.stamp = ros::Time::now();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be the frame timestamp?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christiankerl Technically it should, but the frame timestamp does not use ROS time and the resolution is only seconds, which makes it useless anyway. Need atleast millisecond resolution on the frame stamp for it to be useful. Since I've been seeing on an average 30ms or so processing time per frame, it has to be at least that accurate so that estimators or flight control units can make use of it.

@JakobEngel
Copy link
Member

I added rospose output, however I am not entirely sure whether it is the correct pose (or needs to be the inverse or something). I'm using the timestamp from the original frame message (if it makes sense, i.e. is different from zero, otherwise ros::Time::now()) - as it's seconds with double precision, that amounts to more than millisecond resolution.

@mhkabir
Copy link
Author

mhkabir commented Sep 29, 2014

The pose seems to be correct. One thing I found in testing, when doSLAM was enabled, the pose seemed pretty fine. On turning off doSLAM, the Y and Z axes seem to be reversed.
Any ideas? @JakobEngel

@mhkabir mhkabir closed this Sep 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants