Revised XExtensionItemSource API #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriX
force-pushed
the
master
branch
2 times, most recently
from
e25944e
to
76d97f0
Compare
…he ability to set attributed content text on a per-activity type basis.
| @@ -102,37 +96,23 @@ typedef UIImage *(^XExtensionItemThumbnailProvidingBlock)(CGSize suggestedSize); | |||
| */ | |||
| @property (nonatomic, copy) NSDictionary *userInfo; | |||
|
|
|||
| - (instancetype)initWithURL:(NSURL *)URL; | |||
There was a problem hiding this comment.
Newlines between initializers
There was a problem hiding this comment.
Yeah I wasn't sure how documentation should be handled for this so I just left it unfinished, sorry!
|
I’m just going to open a PR to do some code style consistency work, rather than just slam you with comments :) |
Bunch of cleanup work on top of Ari’s `XExtensionItemSource` refactor
irace
added a commit
that referenced
this pull request
May 13, 2015
Revised XExtensionItemSource API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #43.
Documentation, fixed tests, and code review are still necessary before this should be merged. @irace