Remove Xcode 7 warnings #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ | |||
| <key>CFBundleExecutable</key> | |||
| <string>$(EXECUTABLE_NAME)</string> | |||
| <key>CFBundleIdentifier</key> | |||
| <string>com.tumblr.$(PRODUCT_NAME:rfc1034identifier)</string> | |||
There was a problem hiding this comment.
was this just something that happened with new Xcode?
There was a problem hiding this comment.
Ah, yeah I followed the “upgrade” settings prompt. I can roll this back.
|
I don't know if it's a problem or not but this seems to be built with Xcode 7, which is GM, but not public yet. Your call to merge and tag, probably a non-issue, but will specifying these values in the project file prohibit people not using Xcode 7? |
|
I rolled back the Info.plist changes but don”t want to rollback the project file changes. I'm just going to merge, I don't think anyone is using this and if they are (without Xcode 7) they can just use the previous version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brianmichel