Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collins-client modifies the options hash you give it and it shouldn't #17

Closed
bmatheny opened this issue Sep 8, 2012 · 0 comments
Closed

collins-client modifies the options hash you give it and it shouldn't #17

bmatheny opened this issue Sep 8, 2012 · 0 comments
Assignees
@william-richard
Labels
bug
Milestone
Release 2.0

Comments

@bmatheny
Copy link
Contributor

bmatheny commented Sep 8, 2012

The collins-client ruby gem modifies the options hash used for HTTP related methods. This shouldn't happen, we should deep copy the hash if we need to make modifications.
@ghost ghost assigned bmatheny Sep 8, 2012
wkm pushed a commit that referenced this issue Oct 31, 2012
Merge pull request #17 from tumblr/fibr-pool-expansion
8168794 
Pool expansion added with hover feature and no data labels fixed
dalehamel referenced this issue in Shopify/collins Jun 10, 2014
Merge pull request #17 from tumblr/fibr-pool-expansion
f86a5d1 
Pool expansion added with hover feature and no data labels fixed
dalehamel referenced this issue in Shopify/collins Jun 10, 2014
Merge pull request #17 from tumblr/fibr-pool-expansion
29de581 
Pool expansion added with hover feature and no data labels fixed
@bmatheny bmatheny closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@william-richard william-richard

Labels
bug
Projects
None yet
Milestone
Release 2.0
Development

No branches or pull requests
3 participants
@yl3w @bmatheny @william-richard