Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging if the config is missing #218

Merged
merged 1 commit into from Sep 10, 2014

Conversation

@william-richard
Copy link
Contributor

commented Sep 10, 2014

Attempting to log here causes collins to complain, and everything
can handle it if this returns None anyway

@byxorna

Attempting to log here causes collins to complain, and everything
can handle it if this returns None anyway
@byxorna

This comment has been minimized.

Copy link
Member

commented Sep 10, 2014

Awesome, thanks! Plugins up above the ConfigAccessor already handle the None case with default values, so this really isnt a warning condition.

🍖 🍞 🍺 🍦 merge away!

william-richard pushed a commit that referenced this pull request Sep 10, 2014
Remove logging if the config is missing
@william-richard william-richard merged commit 64eac3e into master Sep 10, 2014
@william-richard william-richard deleted the will-fix-configaccessor-logging branch Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.