Remove logging if the config is missing #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to log here causes collins to complain, and everything can handle it if this returns None anyway
|
Awesome, thanks! Plugins up above the ConfigAccessor already handle the None case with default values, so this really isnt a warning condition. 🍖 🍞 🍺 🍦 merge away! |
william-richard
pushed a commit
that referenced
this pull request
Sep 10, 2014
Remove logging if the config is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to log here causes collins to complain, and everything
can handle it if this returns
Noneanyway@byxorna