Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing or invalid javadoc #115

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Add missing or invalid javadoc #115

merged 2 commits into from
Oct 20, 2017

Conversation

ceyko
Copy link
Contributor

@ceyko ceyko commented Oct 16, 2017

Description

There were a number of places where warnings were showing up due to missing or invalid javadoc. Fix all of them.

Note that this does not add any new javadoc, only fixes existing ones that were triggering warnings.

Add javadoc explaining values used by Post.setState() and Post.getState(). No validation added since it would be a breaking API change, and the API accepts these options liberally.

Fixes #110.

Testing

Make sure there are no typos.

There were a number of places where warnings were showing up due to
missing or invalid javadoc. Fix all of them.
Add javadoc explaining values used by Post.setState() and
Post.getState(). No validation added since it would be a breaking API
change, and the API accepts these options liberally.

Fixes #110
@ceyko ceyko requested a review from jasonpenny October 16, 2017 17:55
@ceyko ceyko changed the title Add all missing javadoc Add missing or invalid javadoc Oct 16, 2017
Copy link

@jasonpenny jasonpenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ceyko ceyko merged commit 2920222 into master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expected input for setState?
2 participants