Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Comparable in Post.java #62

Closed
wants to merge 2 commits into from

Conversation

KevinTCoughlin
Copy link
Contributor

For Discussion: Implement Comparable in the base Post model.

It might be helpful to implement the Comparable interface in the base Post model so that there is a defined way to sort Posts.

/shrug

Worth bumping version if so.

@yl3w
Copy link
Contributor

yl3w commented May 19, 2015

why would the base post compare link posts? Also if we did comparison, I'd expect LinkPost's to be compared by title, url or description?

@KevinTCoughlin
Copy link
Contributor Author

My thought process was that all posts are at least comparable by their id. I don't have a current use case for implementing Comparable so I'm going to close this for the time being.

@KevinTCoughlin KevinTCoughlin deleted the post-comparable branch May 20, 2015 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants