Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VideoPost to return the actual video_url #71

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Linus12
Copy link

@Linus12 Linus12 commented Oct 19, 2015

The VideoPost class is missing the definition and return of the field video_url. This adds this field as a valid return for this class.

The VideoPost class is missing the definition and return of the field video_url. This adds this field as a valid return for this class.
@ericleong
Copy link
Contributor

Could you add the field to VideoPostTest.java?

It's a little bit tricky because there is either a permalink_url (external videos) or video_url (native videos).

Tumblr returns the total number of Draft Posts and the total number Queued posts for a blog, but they were not accessible through Jumblr. This requires an app to step through all the Drafts and Queued posts to "count" them; very much a waste of resources. Since Tumblr returns these values already, these changes allow the application to access the counts without having to "count them".
@Linus12
Copy link
Author

Linus12 commented Nov 7, 2015

Sorry about the changes to "Blog.java" I made other edits that were removed. Unfortunately it looks like the end of file marker changed during the edit, causing the "change" to be included with this one.

@j6mes
Copy link

j6mes commented Jul 2, 2017

Hi. Did this PR ever go into master? I'm having a similar issue and it looks like I might have to fork and run an ad-hoc local build with @Linus12's patch 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants