Avatar requests set no-follow-redirects locally #95
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the final 1.x release of Scribe. Scribe 1.3.5 adds a new method OAuthRequest#setFollowRedirects(), which is needed to be able to (easily) set no-follow on a single request, instead of globally. There were no concerning changes between 1.3.5 and 1.3.7, so we might as well bump to the most recent non-breaking version.
When setting no-follow-redirects for RequestBuilder#getRedirectUrl() (e.g., avatar requests), do so only for this one request. Previously, it was set globally for all requests, then set back to its initial state after the request completed. This should prevent multithreading issues where numerous threads are attempting to alter the global state of HttpURLConnection#setFollowRedirects(). Fixes #94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making an avatar request, or any request using
RequestBuilder#getRedirectUrl(), we need to not follow any redirects, since the response ofgetRedirectUrl()is theLocationof the redirect. Previously, we accomplished this viaHttpURLConnection#setFollowRedirects(). However, this sets it globally, for any callers ofHttpURLConnection.We attempted to have our don't-follow-redirects requirement not affect any other callers by setting it back to its original value after making the request. However, this is not thread-safe. This pull request makes it so that we only change whether redirects are followed for this instance of
HttpURLConnectionby instead usingOAuthRequest#setFollowRedirects(), which callsHttpURLConnection#setInstanceFollowRedirects()internally.The requisite method was only added as of Scribe 1.3.5, so we also needed upgrade the dependency. 1.3.7 is the latest version on the 1.x tree, and there weren't many changes between 1.3.5 and 1.3.7, so we decided to use 1.3.7 instead. I know #83 will obsolete this version upgrade, but just adding it in for now to fix this bug.
cc @ericleong @KevinTCoughlin @bdenney
Fixes #94