Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ansible module names to ansible collections names + remove of deleted ppa + inttention/lengthcheck correction #1

Merged
merged 8 commits into from
Jan 23, 2021

Conversation

TheRojam
Copy link
Collaborator

@TheRojam TheRojam commented Jan 19, 2021

i updated ansible module names to ansible collections names which comes w/ ansible 2.9 atleast since ansible changed module to collections because the lack of name space and declutter.
Therefore i also updated the min_ansible_version to 2.9.
I also removed the stop to add the deleted ppa of wireguard since its now in the ubuntu repositories.
One commit is just a "typo" correction.
May lets improve this this w/ another pr at @botto repo.
Any remarks? lets discuss

@TheRojam
Copy link
Collaborator Author

after this i corrected a wrong intention in the publickeyfile and corrected the check for the empty variables to an check for zero length.
last point was mentioned as warning by ansible-lint.

@TheRojam TheRojam changed the title update ansible module names to ansible collections names + remove of deleted ppa update ansible module names to ansible collections names + remove of deleted ppa + inttention/lengthcheck correction Jan 23, 2021
@amotl
Copy link
Member

amotl commented Jan 23, 2021

Hi Anton,

thank you so much for giving some love to this module. We will be happy if you continue to bring more improvements to the code base, see also #2.

With kind regards,
Andreas.

@amotl amotl merged commit 8420b7b into tunfish:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants