Port PredictionMode #134
Port PredictionMode #134
Conversation
|
|
||
| export namespace PredictionMode { | ||
| /** A Map that uses just the state and the stack context as the key. */ |
There was a problem hiding this comment.
Just a note, I was surprised by this. Given the name "PredictionMode", I expected this to be a simple enum.
There was a problem hiding this comment.
💭 I think a lot of the functionality in PredictionMode could actually be removed from the optimized fork. We'll see at the end.
| @@ -223,7 +241,7 @@ export enum PredictionMode { | |||
| * the configurations to strip out all of the predicates so that a standard | |||
| * {@link ATNConfigSet} will merge everything ignoring predicates.</p> | |||
| */ | |||
| static hasSLLConflictTerminatingPrediction(mode: PredictionMode, @NotNull configs: ATNConfigSet): boolean { | |||
| export function hasSLLConflictTerminatingPrediction(mode: PredictionMode, /*@NotNull*/ configs: ATNConfigSet): boolean { | |||
There was a problem hiding this comment.
This is an example of a place where @NotNull seems to have been commented out unnecessarily. That's not to say I'm arguing for keeping them, I think it reads more clearly if completely eliminated.
There was a problem hiding this comment.
➡️ I've used the comments in a few cases when porting other files. I want to leave them in at least until we're done getting things working. In this case, the function is not a member of a class so decorators are not allowed. Commenting and removing were the only options allowed by the language.
|
OK by me.. Should I remove both code review and comment review flags? |
|
@BurtHarris The needs comment review is a special label for me. I sent you a Gitter message about it. |
No description provided.