-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IconButtonとLikeButtonクラスの定義付け #54
Conversation
IconButtonへの変更を含んでいるので、プルリクエストの名前を変更しておきますね |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
みました!コメントに残したもののほか、いいねが有効の際のみせかたは検討したほうがいいのか気になりました
heart: (fill, stroke) => { | ||
return heart(fill, stroke); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
特定のプロパティをfunctionにするという書き方はすっきりしていていいですね 👍
Co-authored-by: Kimiaki Kuno <knokmki612@gmail.com>
36e22d6 |
Likedというバリアントで表現されていたのですでに実装としては存在していますね |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
上記2つのクラスを分けて管理、共通クラスはiconButtonStyleで管理した。