Add additional queries to 'Other Compliance Checks' #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Khushboo <46913995+khushboo9024@users.noreply.github.com>
…pipe-mod-aws-compliance into extra-check-queries
Co-authored-by: Khushboo <46913995+khushboo9024@users.noreply.github.com>
Co-authored-by: Madhushree Ray <65847563+madhushreeray30@users.noreply.github.com>
rajlearner17
reviewed
Jul 4, 2023
rajlearner17
reviewed
Jul 4, 2023
conformance_pack/vpc.sp
Outdated
| case | ||
| when (select count(*) from vpc_region_list) > 1 then 'VPCs exist in ' || (select count(*) from vpc_region_list) || ' regions.' | ||
| else 'VPC does not exist in more than one region.' |
There was a problem hiding this comment.
@khushboo9024 if there are NO subnets exists, then we can reason
ALARM: test_peering no subnet exists. ..................................................................................... us-east-2 123456781234
rajlearner17
reviewed
Jul 4, 2023
rajlearner17
reviewed
Jul 5, 2023
rajlearner17
reviewed
Jul 5, 2023
rajlearner17
reviewed
Jul 5, 2023
rajlearner17
changed the title
There was a problem hiding this comment.
@khushboo9024 can you please have a look at the comments, thanks!
conformance_pack/iam.sp
Outdated
| from | ||
| aws_iam_policy as p | ||
| left join bad_policies as b on p.arn = b.arn | ||
| where |
There was a problem hiding this comment.
Suggested change
| where | |
| where |
conformance_pack/vpc.sp
Outdated
| } | ||
|
|
||
| control "vpc_subnet_public_and_private" { | ||
| title = "VPCs both public and private subnets should be configured" |
There was a problem hiding this comment.
Suggested change
| title = "VPCs both public and private subnets should be configured" | |
| title = "VPCs should have both public and private subnets configured" |
conformance_pack/vpc.sp
Outdated
| from | ||
| aws_account as a | ||
| left join vpc_count_in_account as v on v.account_id = a.account_id |
There was a problem hiding this comment.
Suggested change
| left join vpc_count_in_account as v on v.account_id = a.account_id | |
| left join vpc_count_in_account as v on v.account_id = a.account_id; |
conformance_pack/iam.sp
Outdated
| @@ -572,6 +572,36 @@ control "iam_policy_no_full_access_to_kms" { | |||
| }) | |||
| } | |||
|
|
|||
| control "iam_role_cross_account_readonlyaccess_policy" { | |||
There was a problem hiding this comment.
Suggested change
| control "iam_role_cross_account_readonlyaccess_policy" { | |
| control "iam_role_cross_account_read_only_access_policy" { |
conformance_pack/iam.sp
Outdated
| control "iam_role_cross_account_readonlyaccess_policy" { | ||
| title = "IAM roles should not have read only access for external AWS accounts" | ||
| description = "Ensure IAM Roles do not have ReadOnlyAccess access for external AWS account. The AWS-managed ReadOnlyAccess policy carries a high risk of potential data leakage, posing a significant threat to customer security and privacy." | ||
| query = query.iam_role_cross_account_readonlyaccess_policy |
There was a problem hiding this comment.
Suggested change
| query = query.iam_role_cross_account_readonlyaccess_policy | |
| query = query.iam_role_cross_account_read_only_access_policy |
conformance_pack/iam.sp
Outdated
| EOQ | ||
| } | ||
|
|
||
| query "iam_securityaudit_role" { |
There was a problem hiding this comment.
Suggested change
| query "iam_securityaudit_role" { | |
| query "iam_security_audit_role" { |
conformance_pack/iam.sp
Outdated
|
|
||
| query "iam_securityaudit_role" { | ||
| sql = <<-EOQ | ||
| with securityaudit_role_count as( |
There was a problem hiding this comment.
Suggested change
| with securityaudit_role_count as( | |
| with security_audit_role_count as( |
conformance_pack/iam.sp
Outdated
| end as reason | ||
| ${local.common_dimensions_global_sql} | ||
| from | ||
| securityaudit_role_count; |
There was a problem hiding this comment.
Suggested change
| securityaudit_role_count; | |
| security_audit_role_count; |
conformance_pack/iam.sp
Outdated
| }) | ||
| } | ||
|
|
||
| control "iam_securityaudit_role" { |
There was a problem hiding this comment.
Suggested change
| control "iam_securityaudit_role" { | |
| control "iam_security_audit_role" { |
conformance_pack/iam.sp
Outdated
| control "iam_securityaudit_role" { | ||
| title = "IAM Security Audit role should be created to conduct security audits" | ||
| description = "Ensure IAM Security Audit role is created. By creating an IAM role with a security audit policy, a distinct segregation of responsibilities is established between the security team and other teams within the organization." | ||
| query = query.iam_securityaudit_role |
There was a problem hiding this comment.
Suggested change
| query = query.iam_securityaudit_role | |
| query = query.iam_security_audit_role |
misraved
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist