Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Update AWS Audit Manager > Control Tower controls. Closes #694 #705

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

Priyanka-Chatterjee-2000
Copy link
Contributor

@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000 commented Aug 3, 2023

Unique controls added:

  • rds_db_instance_encryption_at_rest_enabled
  • ebs_volume_unused

Unique controls removed:

  • ebs_attached_volume_delete_on_termination_enabled
  • rds_db_snapshot_encrypted_at_rest

@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000 linked an issue Aug 3, 2023 that may be closed by this pull request
@Priyanka-Chatterjee-2000 Priyanka-Chatterjee-2000 changed the title Add/Update AWS Audit Manager > Control Tower controls Add/Update AWS Audit Manager > Control Tower controls. Closes #694 Aug 3, 2023
Copy link
Contributor

@rajlearner17 rajlearner17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@madhushreeray30 madhushreeray30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Priyanka-Chatterjee-2000 please have a look at the comments. Please also take a look at the additional feedback as follows:

Formatting is incorrect, please update it for the following files:

  • disallow_instance.sp
  • disallow_internet_connection.sp
  • disallow_public_access.sp
  • ebs_checks.sp
  • multi_factor_authentication.sp

Please end the description for the following with a .

  • audit_manager_control_tower_disallow_internet_connection_2_0_1
  • audit_manager_control_tower_ebs_checks_1_0_2

conformance_pack/ebs.sp Outdated Show resolved Hide resolved
audit_manager_control_tower/disallow_instances.sp Outdated Show resolved Hide resolved
audit_manager_control_tower/ebs_checks.sp Outdated Show resolved Hide resolved
Co-authored-by: Madhushree Ray <65847563+madhushreeray30@users.noreply.github.com>
Copy link
Contributor

@madhushreeray30 madhushreeray30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@misraved misraved merged commit 7d932b9 into release/v0.78 Aug 8, 2023
@misraved misraved deleted the issue#694 branch August 8, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/Update AWS Audit Manager > Control Tower controls
4 participants