[Fix] subscription_id column not displaying wrong value in azure_diagnostic_setting table. Closes #98 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic_setting table. Closes #98
|
|
LalitLab
reviewed
Apr 23, 2021
Comment on lines
185
to
204
| func getDiagnosticSettingResourceGroup(ctx context.Context, d *plugin.QueryData, h *plugin.HydrateData) (interface{}, error) { | ||
| plugin.Logger(ctx).Trace("getDiagnosticSettingResourceGroup") | ||
|
|
||
| var resourseGroupID string | ||
| storage_account_id := h.Item.(insights.DiagnosticSettingsResource).StorageAccountID | ||
| event_hub_authorization_rule_id := h.Item.(insights.DiagnosticSettingsResource).EventHubAuthorizationRuleID | ||
| workspace_id := h.Item.(insights.DiagnosticSettingsResource).WorkspaceID | ||
|
|
||
| if storage_account_id != nil { | ||
| resourseGroupID = strings.Split(*storage_account_id, "/")[4] | ||
| } else if event_hub_authorization_rule_id != nil { | ||
| resourseGroupID = strings.Split(*event_hub_authorization_rule_id, "/")[4] | ||
| } else { | ||
| resourseGroupID = strings.Split(*workspace_id, "/")[4] | ||
| } | ||
|
|
||
| plugin.Logger(ctx).Trace("resourseGroupID", resourseGroupID) | ||
|
|
||
| return resourseGroupID, nil | ||
| } |
There was a problem hiding this comment.
why is this a hydrate function when we are not making any API call in here?
Please convert it to a transform function
LalitLab
suggested changes
Apr 23, 2021
LalitLab
changed the title
LalitLab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test logs
Logs
Example query results
Results