Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self_link for gcp_logging_sink table. closes #190 #193

Merged
merged 2 commits into from
May 12, 2021
Merged

Conversation

sayan133
Copy link
Contributor

@sayan133 sayan133 commented May 7, 2021

Integration test logs

Logs
No env file present for the current environment:  staging 
 Falling back to .env config
No env file present for the current environment:  staging
customEnv TURBOT_TEST_EXPECTED_TIMEOUT undefined

SETUP: tests/gcp_logging_sink []

PRETEST: tests/gcp_logging_sink

TEST: tests/gcp_logging_sink
Running terraform
google_pubsub_topic.named_test_resource: Creating...
google_pubsub_topic.named_test_resource: Creation complete after 9s [id=projects/parker-aaa/topics/turbottest85406]
google_logging_project_sink.named_test_resource: Creating...
google_logging_project_sink.named_test_resource: Creation complete after 8s [id=projects/parker-aaa/sinks/turbottest85406]

Warning: Deprecated Resource

The null_data_source was historically used to construct intermediate values to
re-use elsewhere in configuration, the same can now be achieved using locals


Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

Outputs:

project_id = "parker-aaa"
resource_aka = "gcp://logging.googleapis.com/projects/parker-aaa/sinks/turbottest85406"
resource_id = "projects/parker-aaa/sinks/turbottest85406"
resource_name = "turbottest85406"

Running SQL query: test-get-query.sql
[
  {
    "description": "Test sink to verify the table",
    "destination": "pubsub.googleapis.com/projects/parker-aaa/topics/turbottest85406",
    "disabled": false,
    "filter": "resource.type = gce_route",
    "include_children": false,
    "location": "global",
    "name": "turbottest85406",
    "project": "parker-aaa",
    "self_link": "https://www.googleapis.com/logging/v2/projects/parker-aaa/sinks/turbottest85406"
  }
]
✔ PASSED

Running SQL query: test-hydrate-query.sql
[
  {
    "description": "Test sink to verify the table",
    "destination": "pubsub.googleapis.com/projects/parker-aaa/topics/turbottest85406",
    "disabled": false,
    "filter": "resource.type = gce_route",
    "include_children": false,
    "name": "turbottest85406"
  }
]
✔ PASSED

Running SQL query: test-invalid-name-query.sql
null
✔ PASSED

Running SQL query: test-list-query.sql
[
  {
    "destination": "pubsub.googleapis.com/projects/parker-aaa/topics/turbottest85406",
    "name": "turbottest85406"
  }
]
✔ PASSED

Running SQL query: test-not-found-query.sql
null
✔ PASSED

Running SQL query: test-turbot-query.sql
[
  {
    "akas": [
      "gcp://logging.googleapis.com/projects/parker-aaa/sinks/turbottest85406"
    ],
    "title": "turbottest85406"
  }
]
✔ PASSED

POSTTEST: tests/gcp_logging_sink

TEARDOWN: tests/gcp_logging_sink

SUMMARY:

1/1 passed.

@sayan133 sayan133 requested a review from Subhajit97 May 7, 2021 14:55
@sayan133 sayan133 self-assigned this May 7, 2021
@Subhajit97 Subhajit97 linked an issue May 10, 2021 that may be closed by this pull request
Comment on lines 10 to 11
"project": "{{ output.project_id.value }}",
"self_link": "https://www.googleapis.com/logging/v2/projects/{{ output.project_id.value }}/sinks/{{ resourceName }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation

@Subhajit97 Subhajit97 requested a review from cbruno10 May 10, 2021 15:41
@cbruno10 cbruno10 merged commit 09e0536 into main May 12, 2021
@cbruno10 cbruno10 deleted the issue-190 branch May 12, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add self_link for gcp_logging_sink table.
3 participants