Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table gcp_sql_database_connection_daily closes #229 #240

Merged
merged 9 commits into from
Jun 23, 2021
Merged

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Jun 23, 2021

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results

Basic info

select
  instance_id,
  minimum,
  maximum,
  average,
  sample_count
from
  gcp_sql_database_connection_daily
order by
  instance_id;
+--------------------+---------+---------+-------------------+--------------+
| instance_id        | minimum | maximum | average           | sample_count |
+--------------------+---------+---------+-------------------+--------------+
| parker-aaa:test-db | 8       | 9       | 8.999672131147541 | 3050         |
+--------------------+---------+---------+-------------------+--------------+

Connection Over 8 average

select
  instance_id,
  round(minimum::numeric,2) as min_connection,
  round(maximum::numeric,2) as max_connection,
  round(average::numeric,2) as avg_connection,
  sample_count
from
  gcp_sql_database_connection_daily
where average > 8
order by
  instance_id,
+--------------------+----------------+----------------+----------------+--------------+
| instance_id        | min_connection | max_connection | avg_connection | sample_count |
+--------------------+----------------+----------------+----------------+--------------+
| parker-aaa:test-db | 8.00           | 9.00           | 9.00           | 3050         |
+--------------------+----------------+----------------+----------------+--------------+

Connection daily average < 10

select
  instance_id,
  round(minimum::numeric,2) as min_connection,
  round(maximum::numeric,2) as max_connection,
  round(average::numeric,2) as avg_connection,
  sample_count
from
  gcp_sql_database_connection_daily
where average < 10
order by
  instance_id;
+--------------------+----------------+----------------+----------------+--------------+
| instance_id        | min_connection | max_connection | avg_connection | sample_count |
+--------------------+----------------+----------------+----------------+--------------+
| parker-aaa:test-db | 8.00           | 9.00           | 9.00           | 3050         |
+--------------------+----------------+----------------+----------------+--------------+

@ParthaI ParthaI requested a review from Subhajit97 June 23, 2021 07:15
@ParthaI ParthaI self-assigned this Jun 23, 2021
@ParthaI ParthaI linked an issue Jun 23, 2021 that may be closed by this pull request
@Subhajit97 Subhajit97 requested a review from cbruno10 June 23, 2021 10:43
@cbruno10 cbruno10 requested review from rajlearner17 and removed request for cbruno10 June 23, 2021 13:17
Copy link

@rajlearner17 rajlearner17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbruno10 cbruno10 self-requested a review June 23, 2021 19:18
@cbruno10 cbruno10 merged commit 7f2df06 into main Jun 23, 2021
@cbruno10 cbruno10 deleted the issue-229 branch June 23, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add table gcp_sql_database_instance_metric_connections_daily
4 participants