Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table gcp_compute_disk_metric_read_ops_daily. Closes #220 #264

Merged
merged 7 commits into from
Jul 1, 2021

Conversation

rajeshbal65
Copy link
Contributor

@rajeshbal65 rajeshbal65 commented Jun 29, 2021

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
### Basic info

```sql
select
  name,
  minimum,
  maximum,
  average,
  sample_count
from
  gcp_compute_disk_metric_read_ops_daily
order by
  name;

+------------+---------+---------+---------------------+--------------+
| name       | minimum | maximum | average             | sample_count |
+------------+---------+---------+---------------------+--------------+
| disk-1     | 0       | 74      | 0.07081403044341496 | 1511         |
| disk-1     | 0       | 57      | 0.07556497175141243 | 1416         |
| instance-1 | 0       | 3620    | 11.379219060225017  | 1511         |
| instance-1 | 0       | 4698    | 12.140536723163843  | 1416         |
| instance-1 | 0       | 4006    | 16.01               | 300          |
+------------+---------+---------+---------------------+--------------+

Intervals averaging over 100 read ops

select
  name,
  round(minimum::numeric,2) as min_read_ops,
  round(maximum::numeric,2) as max_read_ops,
  round(average::numeric,2) as avg_read_ops,
  sample_count
from
  gcp_compute_disk_metric_read_ops_daily
where average > 10
order by
  name;

+------------+--------------+--------------+--------------+--------------+
| name       | min_read_ops | max_read_ops | avg_read_ops | sample_count |
+------------+--------------+--------------+--------------+--------------+
| instance-1 | 0.00         | 3620.00      | 11.38        | 1511         |
| instance-1 | 0.00         | 4698.00      | 12.14        | 1416         |
| instance-1 | 0.00         | 4006.00      | 16.01        | 300          |
+------------+--------------+--------------+--------------+--------------+

Intervals averaging fewer than 10 read ops

select
  name,
  round(minimum::numeric,2) as min_read_ops,
  round(maximum::numeric,2) as max_read_ops,
  round(average::numeric,2) as avg_read_ops,
  sample_count
from
  gcp_compute_disk_metric_read_ops_daily
where average < 1
order by
  name;

+--------+--------------+--------------+--------------+--------------+
| name   | min_read_ops | max_read_ops | avg_read_ops | sample_count |
+--------+--------------+--------------+--------------+--------------+
| disk-1 | 0.00         | 74.00        | 0.07         | 1511         |
| disk-1 | 0.00         | 57.00        | 0.08         | 1416         |
+--------+--------------+--------------+--------------+--------------+
</details>

@rajeshbal65 rajeshbal65 self-assigned this Jun 29, 2021
@Subhajit97 Subhajit97 linked an issue Jun 29, 2021 that may be closed by this pull request
@rajeshbal65 rajeshbal65 changed the title Add table gcp_disk_metric_read_ops_daily. Closes #220 Add table gcp_compute_disk_metric_read_ops_daily. Closes #220 Jun 29, 2021
Copy link

@rajlearner17 rajlearner17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Subhajit97 Subhajit97 requested a review from cbruno10 July 1, 2021 09:27
@cbruno10 cbruno10 merged commit fd41b94 into main Jul 1, 2021
@cbruno10 cbruno10 deleted the issue-220 branch July 1, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add table gcp_disk_metric_read_ops_daily
4 participants