-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table gcp_kms_key_version closes #342 #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/tables/gcp_kms_key_version.md
Outdated
crypto_key_version, | ||
state | ||
from | ||
gcp_kms_key_version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcp_kms_key_version; | |
gcp_kms_key_version | |
where state <> 'DESTROYED' |
docs/tables/gcp_kms_key_version.md
Outdated
from | ||
gcp_kms_key_version | ||
where | ||
create_time <= (current_date - interval '30' day) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add where state <> 'DESTROYED'
, this will filter unwanted results
Integration test logs
Logs
Example query results
Results