-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update column title
and add key_name
in table gcp_kms_key_version
#424
Conversation
to have version info Add column `key_name` Remove column `name`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karanpopat I did a quick search through the GCP Insights mod, and found a few instances where we use this table (and potentially the renamed name
column):
cbruno@M1P mods % ge "gcp_kms_key_version" .
./insightsgcp/dashboards/kms/kms_edges.sp: gcp_kms_key_version v
./insightsgcp/dashboards/kms/kms_key_detail.sp: gcp_kms_key_version k
./insightsgcp/dashboards/kms/kms_key_detail.sp: gcp_kms_key_version v
./insightsgcp/dashboards/kms/kms_nodes.sp: gcp_kms_key_version v
./insightsgcp/dashboards/compute/compute_edges.sp: gcp_kms_key_version k
./insightsgcp/dashboards/compute/compute_edges.sp: gcp_kms_key_version as k
./insightsgcp/dashboards/compute/compute_edges.sp: gcp_kms_key_version v
Can you please ensure that as part of the ongoing dashboard updates that these references are updated as well once the GCP plugin dependency is bumped? Thanks!
There is no impact of this change in GCP compliance and thrifty mods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karanpopat Please see suggestions, thanks!
@cbruno10 have updated the files above from GCP insights mod to use the column |
Update column
title
in tablegcp_kms_key_version
to have version infoAdd column
key_name
Remove column
name
Integration test logs
Logs
Example query results
Results