Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update column title and add key_name in table gcp_kms_key_version #424

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

karanpopat
Copy link
Contributor

Update column title in table gcp_kms_key_version to have version info
Add column key_name
Remove column name

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
> select
  key_name,
  crypto_key_version,
  title,
  state
from
  gcp_kms_key_version
where
  state <> 'DESTROYED' limit 5;
+-------------------+--------------------+---------------------+---------+
| key_name          | crypto_key_version | title               | state   |
+-------------------+--------------------+---------------------+---------+
| test-key-name-002 | 3                  | test-key-name-002/3 | ENABLED |
| test-key-name-002 | 7                  | test-key-name-002/7 | ENABLED |
| test-key-name-002 | 1                  | test-key-name-002/1 | ENABLED |
| test-key-name-002 | 2                  | test-key-name-002/2 | ENABLED |
| test-key-name-002 | 5                  | test-key-name-002/5 | ENABLED |
+-------------------+--------------------+---------------------+---------+

@karanpopat karanpopat self-assigned this Jan 2, 2023
@karanpopat karanpopat linked an issue Jan 2, 2023 that may be closed by this pull request
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karanpopat I did a quick search through the GCP Insights mod, and found a few instances where we use this table (and potentially the renamed name column):

cbruno@M1P mods % ge "gcp_kms_key_version" .
./insightsgcp/dashboards/kms/kms_edges.sp:      gcp_kms_key_version v
./insightsgcp/dashboards/kms/kms_key_detail.sp:      gcp_kms_key_version k
./insightsgcp/dashboards/kms/kms_key_detail.sp:      gcp_kms_key_version v
./insightsgcp/dashboards/kms/kms_nodes.sp:      gcp_kms_key_version v
./insightsgcp/dashboards/compute/compute_edges.sp:      gcp_kms_key_version k
./insightsgcp/dashboards/compute/compute_edges.sp:      gcp_kms_key_version as k
./insightsgcp/dashboards/compute/compute_edges.sp:      gcp_kms_key_version v

Can you please ensure that as part of the ongoing dashboard updates that these references are updated as well once the GCP plugin dependency is bumped? Thanks!

@rajlearner17
Copy link

There is no impact of this change in GCP compliance and thrifty mods.

Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karanpopat Please see suggestions, thanks!

gcp/table_gcp_kms_key_version.go Outdated Show resolved Hide resolved
gcp/table_gcp_kms_key_version.go Outdated Show resolved Hide resolved
@karanpopat
Copy link
Contributor Author

@cbruno10 have updated the files above from GCP insights mod to use the column key_name

@misraved misraved merged commit 64169ff into main Jan 11, 2023
@misraved misraved deleted the 423-gcp_kms_key_version branch January 11, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update column title and name in table gcp_kms_key_version
4 participants