-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gcp_cloud_identity_group_membership and gcp_cloud_identity_group tables. Closes #454 #468
Conversation
gcp_cloud_identity_group_membership
gcp_cloud_identity_group_membership
. Closes #454
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karan please can you take a look at the comments? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karanpopat please have a look at the comments, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
gcp_cloud_identity_group_membership
. Closes #454There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karanpopat please take a look at the minor review comment 👍.
|
||
A Membership defines a relationship between a Group and an entity belonging to that Group, referred to as a "member". | ||
|
||
**You must specify the parent resource** under which to list all the `Group` resources. Must be of the form `identitysources/{identity_source}` for external-identity-mapped groups or `customers/{customer}` for Google Groups in the `where` clause (`where parent='C046psxkn'`) to list the identity group memberships. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karanpopat the example queries mentioned by you don't justify the format.
Integration test logs
Logs
Example query results
Results