Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Error in gcp_kubernetes_node_pool table if gke autopilot is used Closes #585 #591

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented May 27, 2024

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
Before fix:

select * from gcp_kubernetes_node_pool

Error: gcp: googleapi: Error 400: Autopilot node pools cannot be accessed or modified.
Details:
[
  {
    "@type": "type.googleapis.com/google.rpc.RequestInfo",
    "requestId": "0xd9eb2e4dcdef82ca"
  }
]
, badRequest (SQLSTATE HV000)

+------+-----------+---------------+--------+--------------+--------------------+---------+--------------------+-------------+------------+--------+---------------------+-----------+------------+---------------------+------------------+-------+------+----------+------->
| name | self_link | location_type | status | cluster_name | initial_node_count | version | pod_ipv4_cidr_size | autoscaling | conditions | config | instance_group_urls | locations | management | max_pods_constraint | upgrade_settings | title | akas | location | projec>
+------+-----------+---------------+--------+--------------+--------------------+---------+--------------------+-------------+------------+--------+---------------------+-----------+------------+---------------------+------------------+-------+------+----------+------->
+------+-----------+---------------+--------+--------------+--------------------+---------+--------------------+-------------+------------+--------+---------------------+-----------+------------+---------------------+------------------+-------+------+----------+------->

Time: 3.1s. Rows returned: 0.

After fix:

> select * from gcp_kubernetes_node_pool
+------+-----------+---------------+--------+--------------+--------------------+---------+--------------------+-------------+------------+--------+---------------------+-----------+------------+---------------------+------------------+-------+------+----------+------->
| name | self_link | location_type | status | cluster_name | initial_node_count | version | pod_ipv4_cidr_size | autoscaling | conditions | config | instance_group_urls | locations | management | max_pods_constraint | upgrade_settings | title | akas | location | projec>
+------+-----------+---------------+--------+--------------+--------------------+---------+--------------------+-------------+------------+--------+---------------------+-----------+------------+---------------------+------------------+-------+------+----------+------->
+------+-----------+---------------+--------+--------------+--------------------+---------+--------------------+-------------+------------+--------+---------------------+-----------+------------+---------------------+------------------+-------+------+----------+-------

@ParthaI ParthaI requested a review from misraved May 27, 2024 08:19
@ParthaI ParthaI self-assigned this May 27, 2024
@ParthaI ParthaI linked an issue May 27, 2024 that may be closed by this pull request
@misraved
Copy link
Contributor

misraved commented Jun 6, 2024

Merging this PR since at the moment there is no way to list/manage the Node pools created by Clusters in auto-pilot mode.

The CLI returns the same error as well.

Autopilot clusters in Google Kubernetes Engine (GKE) manage their node pools automatically, hence for this table, we will be skipping the Clusters that have auto-pilot enabled.

@misraved misraved merged commit 9b3326a into main Jun 6, 2024
1 check passed
@misraved misraved deleted the issue-585 branch June 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in gcp_kubernetes_node_pool table if gke autopilot is used
2 participants