Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin connection messages are written to non-interactive query output if JSON output is enabled leading to invalid JSON #1110

Closed
MichaelBurgess opened this issue Nov 12, 2021 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MichaelBurgess
Copy link
Contributor

Describe the bug
If you have a plugin connection that causes a message to be output to the stdout after launching steampipe (e.g. the paths must be configured message from the CSV plugin), if you run a non-interactive query session in JSON, then that message is output before the JSON, meaning the response from that is not valid JSON.

Steampipe version (steampipe -v)
Example: v0.9.1

To reproduce

  • steampipe plugin install csv
  • steampipe plugin install steampipe
  • steampipe query "select * from steampipe_registry_plugin;" --output json

Expected behavior
Valid JSON is output

@MichaelBurgess MichaelBurgess added the bug Something isn't working label Nov 12, 2021
kaidaguerre added a commit that referenced this issue Nov 15, 2021
…d with plugin name. Do not show plugin error messages in JSON/CSV output. Closes #1110. Closes #1071
@kaidaguerre kaidaguerre modified the milestones: v0.10.0, v0.9.1 Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants