Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugin uninstall output when connections remain #1158

Closed
kaidaguerre opened this issue Nov 23, 2021 · 0 comments · Fixed by #1181
Closed

Improve plugin uninstall output when connections remain #1158

kaidaguerre opened this issue Nov 23, 2021 · 0 comments · Fixed by #1181
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kaidaguerre
Copy link
Contributor

kaidaguerre commented Nov 23, 2021

the current output is a bit messy and confusing. Also the pluralising is wrong:

$ sp plugin uninstall hackernews

The following file has steampipe connections using the 'hackernews' plugin:

        * 'hackernews' in /Users/kai/.steampipe/config/hackernews.spc, line 1

Please remove them to continue using steampipe

Uninstalled plugin hackernews

Maybe should be more like:

$ sp plugin uninstall hackernews

Uninstalled plugin hackernews

Note: the following file has a steampipe connectionsusing the 'hackernews' plugin:
        *  file: /Users/kai/.steampipe/config/hackernews.spc 
           connection: 'hackernews' (line 1)

Please remove it to continue using steampipe
$ sp plugin uninstall hackernews

Uninstalled plugin hackernews

Note: the following file has steampipe connections using the 'hackernews' plugin:
        *  file: /Users/kai/.steampipe/config/hackernews.spc 
           connection: 'hackernews' (line 1)
           connection: 'hackernews2' (line 8)


Please remove it to continue using steampipe
$ sp plugin uninstall hackernews

Uninstalled plugin hackernews

Note: the following files have steampipe connections using the 'hackernews' plugin:
        *  file: /Users/kai/.steampipe/config/hackernews.spc 
           connection: 'hackernews' (line 1)
        *  file: /Users/kai/.steampipe/config/hackernews2.spc 
           connection: 'hackernews2' (line 1)
           connection: 'hackernews3' (line 8)

Please remove them to continue using steampipe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants